Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

244: Legacy reviewers jcheck configuration does not reset default #378

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jan 23, 2020

Hi all,

please review this patch that fixes an issue with the parsing of the older
format of the "reviewers" jcheck configuration. The problem is that the defaults
weren't reset when parsing the older format, so if a repository has a
.jcheck/conf containing the following

[checks "reviewer"]
minimum = 1
role = committer

then the outcome would be the that jcheck would require 1 Reviewer and 1
Committer (since the default is 1 Reviewer).

The fix is to reset the defaults to zero when parsing the older format.

Thanks,
Erik

Testing

  • Added a new unit test for the above scenario

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-244: Legacy reviewers jcheck configuration does not reset default

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 23, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jan 23, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 23, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Jan 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 24, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

244: Legacy reviewers jcheck configuration does not reset default

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 24, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jan 24, 2020

/integrate

@openjdk openjdk bot closed this Jan 24, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 24, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 7a6119d: 223: Make required re-reviewing configurable
  • 8b3b386: 217: Enforce check on number of required reviewers
  • 73dda3f: 241: Gradle version plugin should allow a version.txt file
  • 5efaf03: 239: Add link to pull requests to automatically generated webrevs
  • db6fbee: 238: Add link to upstream repository to generated webrevs

Your commit was automatically rebased without conflicts.

Pushed as commit b0a9758.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 24, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: b0a9758
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-01-24 06:58:54 +0000
URL: https://git.openjdk.java.net/skara/commit/b0a97589

244: Legacy reviewers jcheck configuration does not reset default

Reviewed-by: rwestberg

! jcheck/src/main/java/org/openjdk/skara/jcheck/ReviewersConfiguration.java
! jcheck/src/test/java/org/openjdk/skara/jcheck/ReviewersCheckTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants