Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

245: CLI tools do not consider git's http.proxy configuration #379

Closed
wants to merge 2 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jan 24, 2020

Hi all,

please review this patch that makes the CLI tools respect git's
http.proxy
setting. The behavior with this patch is if http_proxy, https_proxy and/or
no_proxy is not set, then we try to set the proxy based on git's
http.proxy config (i.e. http_proxy and friends have precedence).

Thanks,
Erik

Testing

  • Manual testing of CLI tools behind http(s) proxy

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-245: CLI tools do not consider git's http.proxy configuration

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 24, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jan 24, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 24, 2020

Webrevs

@rwestberg
Copy link
Member

@rwestberg rwestberg commented Jan 24, 2020

Should the precedence order perhaps be changed to match how git treats the configuration?

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Jan 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 24, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

245: CLI tools do not consider git's http.proxy configuration

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 24, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 24, 2020

Mailing list message from Erik Helin on skara-dev:

On 1/24/20 9:01 AM, Robin Westberg wrote:

Should the precedence order perhaps be changed to match how git treats the configuration?

Yeah, that makes sense. I pushed a new version!

Thanks,
Erik

@edvbld
Copy link
Member Author

@edvbld edvbld commented Jan 24, 2020

/integrate

@openjdk openjdk bot closed this Jan 24, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 24, 2020

@edvbld
Pushed as commit 1b57804.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 24, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 1b57804
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-01-24 09:50:44 +0000
URL: https://git.openjdk.java.net/skara/commit/1b578044

245: CLI tools do not consider git's http.proxy configuration

Reviewed-by: rwestberg

! proxy/src/main/java/org/openjdk/skara/proxy/HttpProxy.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants