218: Enforce check on approval of CSRs

[edvbld]

Hi all,

please review this patch that adds a CSR bot. The CSR bot allows a reviewer to
issue the command /csr in a pull request comment. Once issued, the PR cannot
be integrated until the CSR for the issue associated with the PR is in state
"Closed" and "Approved". A reviewer can cancel this requirement by issuing the
command /csr unneeded in a pull request comment.

Testing:

• Added a bunch of new unit tests for the /csr command and the CSR bot
• sh gradlew test passes on Linux x64

Thanks,
Erik

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

SKARA-218: Enforce check on approval of CSRs

Approvers

• Robin Westberg (rwestberg - Reviewer) Note! Review applies to 76d62dd

[bridgekeeper]

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[mlbridge]

Webrevs

• 02: Full - Incremental (800212d)
• 01: Full - Incremental (c68a467)
• 00: Full (76d62dd)

[edvbld]

/test

[openjdk]

A test job has been started with id: github.com-193500053-385-579313666

[openjdk]

@edvbld your test job with id github.com-193500053-385-579313666 for commits up until 76d62dd has finished.

[rwestberg]

Looks good, mostly have some spelling suggestions. 😃

[openjdk]

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

218: Enforce check on approval of CSRs

Reviewed-by: rwestberg

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

[edvbld]

/integrate

[openjdk]

@edvbld The following commits have been pushed to master since your change was applied:

• 77ae4d8: 247: Support atomic pushes in with /integrate command
• 1325136: 248: Only post integration messages to RFR threads once

Your commit was automatically rebased without conflicts.

Pushed as commit f40d58e.

[mlbridge]

Mailing list message from Erik Helin on skara-dev:

Changeset: f40d58e
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-01-29 08:38:20 +0000
URL: https://git.openjdk.java.net/skara/commit/f40d58ed

218: Enforce check on approval of CSRs

Reviewed-by: rwestberg

! bots/cli/build.gradle
+ bots/csr/build.gradle
+ bots/csr/src/main/java/module-info.java
+ bots/csr/src/main/java/org/openjdk/skara/bots/csr/CSRBot.java
+ bots/csr/src/main/java/org/openjdk/skara/bots/csr/CSRBotFactory.java
+ bots/csr/src/test/java/org/openjdk/skara/bots/csr/CSRBotTests.java
+ bots/pr/src/main/java/org/openjdk/skara/bots/pr/CSRCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandWorkItem.java
+ bots/pr/src/test/java/org/openjdk/skara/bots/pr/CSRTests.java
! settings.gradle