Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

218: Enforce check on approval of CSRs #385

Closed
wants to merge 3 commits into from
Closed

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jan 28, 2020

Hi all,

please review this patch that adds a CSR bot. The CSR bot allows a reviewer to
issue the command /csr in a pull request comment. Once issued, the PR cannot
be integrated until the CSR for the issue associated with the PR is in state
"Closed" and "Approved". A reviewer can cancel this requirement by issuing the
command /csr unneeded in a pull request comment.

Testing:

  • Added a bunch of new unit tests for the /csr command and the CSR bot
  • sh gradlew test passes on Linux x64

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-218: Enforce check on approval of CSRs

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 28, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 28, 2020

Webrevs

@edvbld
Copy link
Member Author

@edvbld edvbld commented Jan 28, 2020

/test

@openjdk
Copy link

@openjdk openjdk bot commented Jan 28, 2020

A test job has been started with id: github.com-193500053-385-579313666

@openjdk
Copy link

@openjdk openjdk bot commented Jan 28, 2020

@edvbld your test job with id github.com-193500053-385-579313666 for commits up until 76d62dd has finished.

Copy link
Member

@rwestberg rwestberg left a comment

Looks good, mostly have some spelling suggestions. 😃

@openjdk
Copy link

@openjdk openjdk bot commented Jan 29, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

218: Enforce check on approval of CSRs

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 29, 2020
edvbld and others added 2 commits Jan 29, 2020
Thanks Robin!

Co-Authored-By: Robin Westberg <robin@westberg.se>
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jan 29, 2020

/integrate

@openjdk openjdk bot closed this Jan 29, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 29, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 77ae4d8: 247: Support atomic pushes in with /integrate command
  • 1325136: 248: Only post integration messages to RFR threads once

Your commit was automatically rebased without conflicts.

Pushed as commit f40d58e.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 29, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: f40d58e
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-01-29 08:38:20 +0000
URL: https://git.openjdk.java.net/skara/commit/f40d58ed

218: Enforce check on approval of CSRs

Reviewed-by: rwestberg

! bots/cli/build.gradle
+ bots/csr/build.gradle
+ bots/csr/src/main/java/module-info.java
+ bots/csr/src/main/java/org/openjdk/skara/bots/csr/CSRBot.java
+ bots/csr/src/main/java/org/openjdk/skara/bots/csr/CSRBotFactory.java
+ bots/csr/src/test/java/org/openjdk/skara/bots/csr/CSRBotTests.java
+ bots/pr/src/main/java/org/openjdk/skara/bots/pr/CSRCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandWorkItem.java
+ bots/pr/src/test/java/org/openjdk/skara/bots/pr/CSRTests.java
! settings.gradle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants