Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

182: Implement a cooldown period when bridging pull request comments to mailing lists #386

Closed
wants to merge 2 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jan 30, 2020

Hi all,

Please review this change that implements waiting for a configured period of time before bridging PR comments to mailing lists. It also contains a refactoring to construct the mailing list bridge bot with a builder.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-182: Implement a cooldown period when bridging pull request comments to mailing lists

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 30, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 30, 2020

Webrevs

edvbld
edvbld approved these changes Jan 30, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, thanks for fixing this!

@openjdk
Copy link

@openjdk openjdk bot commented Jan 30, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

182: Implement a cooldown period when bridging pull request comments to mailing lists

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate f40d58edb7a5da1c0d2adbec65a00d082a8cb84d.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 30, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jan 30, 2020

/integrate

@openjdk openjdk bot closed this Jan 30, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 30, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 30, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • f40d58e: 218: Enforce check on approval of CSRs
  • 77ae4d8: 247: Support atomic pushes in with /integrate command

Your commit was automatically rebased without conflicts.

Pushed as commit b760927.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 30, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: b760927
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-01-30 11:15:56 +0000
URL: https://git.openjdk.java.net/skara/commit/b760927d

182: Implement a cooldown period when bridging pull request comments to mailing lists

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java
+ bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotBuilder.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBotTests.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants