Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

256: Multiple [Integrated] messages can still be sent #391

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 4, 2020

Hi all,

Please review this follow-up fix for SKARA-248.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-256: Multiple [Integrated] messages can still be sent

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 4, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

edvbld
edvbld approved these changes Feb 4, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, thanks for fixing!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

256: Multiple [Integrated] messages can still be sent

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 39831e68cfe8125ffe91d6a0afca54d98849e739.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 4, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 4, 2020

Webrevs

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Feb 4, 2020

/integrate

@openjdk openjdk bot closed this Feb 4, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 4, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 4, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 833d8ed: Fix problem with ignoring links in Jira

Your commit was automatically rebased without conflicts.

Pushed as commit 39831e6.

@openjdk openjdk bot removed the rfr label Feb 4, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 4, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 39831e6
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-02-04 09:28:25 +0000
URL: https://git.openjdk.java.net/skara/commit/39831e68

256: Multiple [Integrated] messages can still be sent

Reviewed-by: ehelin

! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java
! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java
! test/src/main/java/org/openjdk/skara/test/TestMailmanServer.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants