Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

257: Proper setting of custom fields in Jira issues #392

Closed
wants to merge 3 commits into from
Closed

257: Proper setting of custom fields in Jira issues #392

wants to merge 3 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 4, 2020 •
edited by openjdk[bot] bot

Hi all,

Please review this change that properly sets custom fields when creating Jira issues.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-257: Proper setting of custom fields in Jira issues

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 4, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 4, 2020 •
edited

Webrevs

edvbld
edvbld approved these changes Feb 6, 2020
View changes
Copy link
Member

@edvbld edvbld left a comment

Looks good! Just a minor nit: since this patch was created the JSON API has gotten the possibility to query JSONValue objects for their type using is* methods (e.g. isObject()). If you merge master into this PR then you will be able to use these new methods 👍

issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java Outdated
if (!name.startsWith("customfield_")) {
return unfiltered;
}
if (unfiltered instanceof JSONObject) {
Copy link
Member

@edvbld edvbld Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (unfiltered instanceof JSONObject) {
if (unfiltered.isObject()) {

@openjdk
Copy link

@openjdk openjdk bot commented Feb 6, 2020 •
edited

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

257: Proper setting of custom fields in Jira issues

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 6, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Feb 6, 2020

/integrate

@openjdk openjdk bot closed this Feb 6, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 6, 2020

@rwestberg
Pushed as commit 72c721a.

@openjdk openjdk bot removed the rfr label Feb 6, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 6, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 72c721a
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-02-06 10:31:19 +0000
URL: https://git.openjdk.java.net/skara/commit/72c721a2

257: Proper setting of custom fields in Jira issues

Reviewed-by: ehelin

! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edvbld edvbld

Assignees
No one assigned
Labels
bots integrated
Milestone
No milestone
2 participants
@rwestberg @edvbld