Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge-bot: use correct credentials for listing PRs #410

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 7, 2020

Hi all,

please review this small patch that fixes some additional credential confusion
in the merge bot. The bot did not use correct credentials for listing the pull
requests for the target repository.

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 7, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 7, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

merge-bot: use correct credentials for listing PRs

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 7, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Feb 7, 2020

/integrate

@openjdk openjdk bot closed this Feb 7, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 7, 2020

@edvbld
Pushed as commit 099d715.

@openjdk openjdk bot removed the rfr label Feb 7, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 7, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants