Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve materialization speed #411

Closed
wants to merge 7 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 7, 2020

Hi all,

Please review this change that allows materializing a HostedRepository using a common shared "seed", and make use of it in the PR bot.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 7, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

mlbridge bot commented Feb 7, 2020

Webrevs

edvbld
edvbld approved these changes Feb 10, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Feb 10, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Improve materialization speed

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate a67c3c1ae4623cb3c5b0644d975fbffc60fa76cd.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 10, 2020
@rwestberg
Copy link
Member Author

rwestberg commented Feb 10, 2020

/integrate

@openjdk openjdk bot closed this Feb 10, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 10, 2020
@openjdk
Copy link

openjdk bot commented Feb 10, 2020

@rwestberg
Pushed as commit a67c3c1.

@openjdk openjdk bot removed the rfr label Feb 10, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 10, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: a67c3c1
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-02-10 13:08:20 +0000
URL: https://git.openjdk.java.net/skara/commit/a67c3c1a

Improve materialization speed

Reviewed-by: ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/LabelerWorkItem.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotBuilder.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/SponsorCommand.java
+ forge/src/main/java/org/openjdk/skara/forge/HostedRepositoryPool.java
! jcheck/src/test/java/org/openjdk/skara/jcheck/TestRepository.java
! vcs/src/main/java/org/openjdk/skara/vcs/Repository.java
! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java
! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants