Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch PRs using the head hash #417

wants to merge 1 commit into from


Copy link

@rwestberg rwestberg commented Feb 10, 2020

Hi all,

Please review this follow-up fix for faster remote repository materialization that fetches PRs by their head hash instead of a named source ref, as the ref may not be present in the remote repo.

Best regards,


  • Change must not contain extraneous whitespace
  • Change must be properly reviewed


  • Erik Helin (ehelin - Reviewer)

Copy link

@bridgekeeper bridgekeeper bot commented Feb 10, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 10, 2020
edvbld approved these changes Feb 10, 2020
Copy link

@edvbld edvbld left a comment

Looks good!

Copy link

@openjdk openjdk bot commented Feb 10, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Fetch PRs using the head hash

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 21d6acf9a5f5ff6e255962a912941443b77f8324.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 10, 2020
Copy link

@mlbridge mlbridge bot commented Feb 10, 2020


Copy link
Member Author

@rwestberg rwestberg commented Feb 11, 2020


@openjdk openjdk bot closed this Feb 11, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 11, 2020
Copy link

@openjdk openjdk bot commented Feb 11, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • a865b97: Always set commit_id and comments when adding review
  • 0cb32dd: git-pr: status cannot handle rfr label correctly

Your commit was automatically rebased without conflicts.

Pushed as commit 21d6acf.

Copy link

@mlbridge mlbridge bot commented Feb 11, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 21d6acf
Author: Robin Westberg <rwestberg at>
Date: 2020-02-11 06:50:45 +0000

Fetch PRs using the head hash

Reviewed-by: ehelin

! forge/src/main/java/org/openjdk/skara/forge/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants