Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness of removing invalid clones #420

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 11, 2020

Hi all,

Please review this change that improves the removal of invalid clones. The preservation is only meant to aid debugging, so any problems in that area should not throw any exception.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 11, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 11, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 11, 2020

Webrevs

edvbld
edvbld approved these changes Feb 11, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Improve robustness of removing invalid clones

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 11, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Feb 11, 2020

/integrate

@openjdk openjdk bot closed this Feb 11, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2020

@rwestberg
Pushed as commit 1d56042.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 11, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 1d56042
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-02-11 07:52:59 +0000
URL: https://git.openjdk.java.net/skara/commit/1d560423

Improve robustness of removing invalid clones

Reviewed-by: ehelin

! forge/src/main/java/org/openjdk/skara/forge/HostedRepositoryPool.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants