Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a stable creation date for new revisions #422

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 11, 2020

Hi all,

Please review this change that ensures that a stable creation date is used when creating emails for new content in a PR. Otherwise they may get stuck in cooldown forever.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 11, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

edvbld
edvbld approved these changes Feb 11, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Use a stable creation date for new revisions

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 132bd38b0b04e751607dbf6a6fb8fabe5d1fb4da.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 11, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 11, 2020

Webrevs

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Feb 11, 2020

/integrate

@openjdk openjdk bot closed this Feb 11, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 132bd38: contributor command: better validation of input

Your commit was automatically rebased without conflicts.

Pushed as commit 67e9843.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 11, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 67e9843
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-02-11 10:02:14 +0000
URL: https://git.openjdk.java.net/skara/commit/67e9843f

Use a stable creation date for new revisions

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants