Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-bot: throw on unexpected jcheck issues #423

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 11, 2020

Hi all,

please carefully review this patch that throws IllegalStateException for
some jcheck issues that shouldn't happen for commits that the PR bot has
created. I think I have gone through all cases, but would appreciate careful
reviewing here 馃槃

Testing:

  • make test passes on Linux x64

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 11, 2020

馃憢 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 11, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

After careful consideration, I declare this to be looking good.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

pr-bot: throw on unexpected jcheck issues

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b7fd5b63ba0de30263381e0f8d5bff88758639c4.

鉃★笍 To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 11, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Feb 11, 2020

/integrate

@openjdk openjdk bot closed this Feb 11, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 11, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • b7fd5b6: contributor command: friendlier message when removing contributor
  • 77105e6: Standardize pr bot scratch folder names and detect invalid directories
  • 67e9843: Use a stable creation date for new revisions
  • 132bd38: contributor command: better validation of input

Your commit was automatically rebased without conflicts.

Pushed as commit 8a386af.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 11, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 8a386af
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-02-11 13:15:10 +0000
URL: https://git.openjdk.java.net/skara/commit/8a386afc

pr-bot: throw on unexpected jcheck issues

Reviewed-by: rwestberg

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants