Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing of GitHub PositionMapper #43

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Aug 14, 2019

Hi all,

Please review this test of the GitHub PositionMapper (which also found an off-by-one bug).

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@openjdk openjdk bot added the rfr label Aug 14, 2019
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 14, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 14, 2019

Webrevs

edvbld
edvbld approved these changes Aug 14, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Aug 14, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 14, 2019

@rwestberg This change can now be integrated. The commit message will be:

Improve testing of GitHub PositionMapper

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • d4ab5fd: 55: Reduce disk usage for notify bot

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 14, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Aug 16, 2019

/integrate

@openjdk openjdk bot closed this Aug 16, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 16, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 39f574e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants