Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

263: Add target repo and branch to subject of RFR email #431

Closed
wants to merge 3 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 12, 2020

Hi all,

Please review this change that optionally adds the name of the target repo and/or branch to the subject line of an RFR email.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-263: Add target repo and branch to subject of RFR email

Approvers

Robin Westberg added 2 commits Feb 12, 2020
# Conflicts:
#	bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java
#	bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java
#	bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 12, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 12, 2020

Webrevs

edvbld
edvbld approved these changes Feb 12, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, nice feature!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 12, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

263: Add target repo and branch to subject of RFR email

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 12, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 12, 2020

Will this exclude the master branch? What I want is the branch name to be displayed only if it is other than master.

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Feb 12, 2020

Yes, it is configured with a regular expression regarding which branch names to show. In your case, we can set it to something like jfx.* or even ^(?!.*master).*$.

# Conflicts:
#	bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java
#	bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotBuilder.java
#	bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java
@openjdk openjdk bot removed the outdated label Feb 13, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Feb 13, 2020

/integrate

@openjdk openjdk bot closed this Feb 13, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 13, 2020

@rwestberg
Pushed as commit e04fed3.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 13, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: e04fed3
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-02-13 10:37:48 +0000
URL: https://git.openjdk.java.net/skara/commit/e04fed3a

263: Add target repo and branch to subject of RFR email

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotBuilder.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants