Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkout instructions to PR body #434

Closed
wants to merge 6 commits into from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Feb 13, 2020

Hi,

I'd like let the pr bot add the fetch comamnd found in the automatic emails to the PR body, so that people using only GitHub can see the instructions as well.

This adds a new "Instructions" section to the body of the PR message:

Instructions

To checkout these changes locally:

$ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16
$ git checkout pull/16

Testing:

  • Running .\gradlew test

Any other recommendations for testing this?

Thanks,
Jorn

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 13, 2020

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 13, 2020

@edvbld
Copy link
Member

@edvbld edvbld commented Feb 13, 2020

Thanks Jorn, good idea 👍 I think we might want to overhaul the design a little bit to accommodate for this new section. I added in some more sections that might appear in a pull request - what do you think about the following?


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1/2)

Issues

  • JDK-8712393: Add download instructions to pull request

Contributors

Reviewers

  • Erik Duveblad (ehelin - Reviewer)
  • Joe Darcy (darcy - Reviewer) 🔄 Re-review required (review applies to 7de15f5)

Download

$ git fetch https://git.openjdk.java.net/panama-foreign pull/16/head:pull/16
$ git checkout pull/16

@JornVernee
Copy link
Member Author

@JornVernee JornVernee commented Feb 17, 2020

Hey Erik,

I like the new format that you suggest as well :) I've applied the suggestions.

Copy link
Member

@edvbld edvbld left a comment

Nice work! Just a small nit, you can use a Markdown thematic break instead of using the <hr /> HTML tag directly.

Co-Authored-By: Erik Duveblad <erik.helin@oracle.com>
@edvbld
Copy link
Member

@edvbld edvbld commented Feb 18, 2020

It seems like the test org.openjdk.skara.bots.pr.ContributorTests > prBodyUpdates is failing on both Linux and Mac. I think you have to change these two lines:

@JornVernee
Copy link
Member Author

@JornVernee JornVernee commented Feb 18, 2020

@edvbld Thanks Erik,

That test is being skipped when running on Windows and I'm seeing a lot of "STANDARD_ERROR"s in the build log for the workflow, so not sure if this was a false negative.

I gave the latest version a run on WSL. There are a lot of failing tests if I do that, unrelated to this PR, but at least the particular test is now passing.

@edvbld
Copy link
Member

@edvbld edvbld commented Feb 18, 2020

@JornVernee Yeah, most of the bot tests are disabled on Windows. I would be happy to review patches to get the tests passing on WSL 👍

edvbld
edvbld approved these changes Feb 18, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2020

@JornVernee This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Add checkout instructions to PR body

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 7 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 01d1519b88623625b28a65a967464e09b6fd46ae.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 18, 2020
@JornVernee
Copy link
Member Author

@JornVernee JornVernee commented Feb 18, 2020

/integrate

@openjdk openjdk bot closed this Feb 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2020

@JornVernee The following commits have been pushed to master since your change was applied:

  • 01d1519: git-pr: recognize more forms on integration comments
  • b277057: git-pr: support atomic integrations
  • 16182f5: Use seeded materialization for notifier, fix potential race condition
  • d5b6d4c: git-webrev: create links for bug ids in commit messages
  • 64bc771: 275: PR bot should allows merge-style PRs with only branch names
  • e4b8ae3: 280: Notifier should support repo/branch prefixes
  • 38bc15e: git-webrev: show commit messages

Your commit was automatically rebased without conflicts.

Pushed as commit 84a1235.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2020

Mailing list message from Jorn Vernee on skara-dev:

Changeset: 84a1235
Author: Jorn Vernee <jvernee at openjdk.org>
Date: 2020-02-18 12:20:25 +0000
URL: https://git.openjdk.java.net/skara/commit/84a1235c

Add checkout instructions to PR body

Reviewed-by: ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/ContributorTests.java

@JornVernee JornVernee deleted the checkout_command_in_pr branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants