Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HostUserDetails::email #436

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 13, 2020

Hi all,

please review this patch that adds the method HostUserDetails::email. It is
rare for user to have public emails, but the bots can now take advantage of
those rare cases.

Testing:

  • make test on Linux x64 passes

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 13, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Feb 14, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Add HostUserDetails::email

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 10 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 4c469bf082299e50ed61a6a58f693fb79c97dca8.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 14, 2020
@edvbld
Copy link
Member Author

edvbld commented Feb 14, 2020

/integrate

@openjdk openjdk bot closed this Feb 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 14, 2020
@openjdk
Copy link

openjdk bot commented Feb 14, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 57f1d63: Make Host::user return Optional
  • c23c574: vcs: add support for Mercurial 5.3
  • 3857844: pr-bot: add contributors to summary
  • f8a0b66: test-bot: better logging for IOException
  • e18cfc5: Check updated PRs for mailing list archive bridging
  • e04fed3: 263: Add target repo and branch to subject of RFR email
  • f06967e: Configure the mlbridge seed folder properly
  • 4b961c8: Use seeded materialization when generating mails
  • 9b9160b: Fix parsing of editor commandline in git-pr

Your commit was automatically rebased without conflicts.

Pushed as commit 4c469bf.

@mlbridge
Copy link

mlbridge bot commented Feb 14, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 4c469bf
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-02-14 10:52:30 +0000
URL: https://git.openjdk.java.net/skara/commit/4c469bf0

Add HostUserDetails::email

Reviewed-by: rwestberg

! forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java
! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabHost.java
! host/src/main/java/org/openjdk/skara/host/HostUser.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants