Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

270: Remove ignored reviews from the summary #437

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 14, 2020

Hi all,

Please review this change that when a project is configured to ignore stale reviews, the PR body is updated to reflect the status of reviews that are no longer applicable.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-270: Remove ignored reviews from the summary

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 14, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 14, 2020

Webrevs

edvbld
edvbld approved these changes Feb 14, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 14, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

270: Remove ignored reviews from the summary

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 4c469bf082299e50ed61a6a58f693fb79c97dca8.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 14, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Feb 14, 2020

/integrate

@openjdk openjdk bot closed this Feb 14, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 14, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 4c469bf: Add HostUserDetails::email
  • 57f1d63: Make Host::user return Optional
  • c23c574: vcs: add support for Mercurial 5.3

Your commit was automatically rebased without conflicts.

Pushed as commit 7f3f4b2.

@openjdk openjdk bot removed the rfr label Feb 14, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 14, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 7f3f4b2
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-02-14 13:31:18 +0000
URL: https://git.openjdk.java.net/skara/commit/7f3f4b2e

270: Remove ignored reviews from the summary

Reviewed-by: ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants