Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcs: add support for Mercurial 5.3 #438

Closed
wants to merge 1 commit into from
Closed

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 14, 2020

Hi all,

please review this patch that adds support for Mercurial 5.3. Mercurial changed its internal API slightly for 5.3, see here for the relevant commit. The fix is simple, just make a tuple for the returned value repo.status.

Testing:

  • make test with both hg 4.9 and 5.3

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 14, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 14, 2020
@rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 14, 2020

Great, let's see if the mac build is happy now.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 14, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

All builds passed, looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 14, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

vcs: add support for Mercurial 5.3

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 14, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Feb 14, 2020

/integrate

@openjdk openjdk bot closed this Feb 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 14, 2020

@edvbld
Pushed as commit c23c574.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 14, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: c23c574
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-02-14 10:50:51 +0000
URL: https://git.openjdk.java.net/skara/commit/c23c574f

vcs: add support for Mercurial 5.3

Reviewed-by: rwestberg

! vcs/src/main/resources/ext.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants