Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-webrev: show commit messages #441

Closed
wants to merge 3 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 17, 2020

Hi all,

please review this patch that adds commit messages to webrevs (if applicable).
The current MetadataFormatter is a bit bare-bones, I plan to enhance it in
future patches. I had to implement a few overloads of commitMetadata to
support this feature, hence the changes to vcs.

Testing:

  • Added unit tests for commitMetadata
  • Manual testing of git-webrev for both Git and Mercurial repositories

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 17, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 17, 2020
@edvbld edvbld changed the title git-pr: show commit messages git-webrev: show commit messages Feb 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 17, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git-webrev: show commit messages

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 17, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Feb 17, 2020

/integrate

@openjdk openjdk bot closed this Feb 17, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2020

@edvbld
Pushed as commit 38bc15e.

@openjdk openjdk bot removed the rfr label Feb 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 17, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 38bc15e
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-02-17 15:04:20 +0000
URL: https://git.openjdk.java.net/skara/commit/38bc15ef

git-webrev: show commit messages

Reviewed-by: rwestberg

! jcheck/src/test/java/org/openjdk/skara/jcheck/TestRepository.java
! vcs/src/main/java/org/openjdk/skara/vcs/ReadOnlyRepository.java
! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java
! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java
! vcs/src/main/resources/ext.py
! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java
! webrev/src/main/java/org/openjdk/skara/webrev/AddedFileView.java
+ webrev/src/main/java/org/openjdk/skara/webrev/MetadataFormatter.java
! webrev/src/main/java/org/openjdk/skara/webrev/ModifiedFileView.java
! webrev/src/main/java/org/openjdk/skara/webrev/RemovedFileView.java
! webrev/src/main/java/org/openjdk/skara/webrev/Webrev.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants