Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

280: Notifier should support repo/branch prefixes #442

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 17, 2020

Hi all,

Please review this change that add support for repo/branch prefixes to the mails sent by the PR notifier.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-280: Notifier should support repo/branch prefixes

Reviewers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

mlbridge bot commented Feb 17, 2020

Webrevs

edvbld
edvbld approved these changes Feb 17, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Feb 17, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

280: Notifier should support repo/branch prefixes

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e4b8ae3d065d8a967f56515d290597c82b37d492.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 17, 2020
@rwestberg
Copy link
Member Author

rwestberg commented Feb 17, 2020

/integrate

@openjdk openjdk bot closed this Feb 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 17, 2020
@openjdk
Copy link

openjdk bot commented Feb 17, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 38bc15e: git-webrev: show commit messages

Your commit was automatically rebased without conflicts.

Pushed as commit e4b8ae3.

@mlbridge
Copy link

mlbridge bot commented Feb 17, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: e4b8ae3
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-02-17 15:59:58 +0000
URL: https://git.openjdk.java.net/skara/commit/e4b8ae3d

280: Notifier should support repo/branch prefixes

Reviewed-by: ehelin

! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdaterBuilder.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/NotifyBotFactory.java
! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants