Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-webrev: create links for bug ids in commit messages #444

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 17, 2020

Hi all,

please review this patch that creates links to
JBS for issue id:s in commit messages. This
patch also creates a link to the upstream revision if possible. Finally I also
updated some of the titles to match webrev.ksh.

The reason for not using the types IssueProject and PullRequest is that
webrev.ksh has traditionally never required a network connection. The bots
however are free to do so and can therefore provide better implementations for
issueLinker and commitLinker. This work will be done in a follow-up patch.

Testing:

  • make test passes on Linux x64
  • Manual testing of git-webrev

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 17, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 17, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

Just wanted to note that webrev.ksh actually does attempt to fetch the issue title from JBS:

        if [[ -n $WGET ]]; then
            msg=`$WGET --timeout=10 --tries=1 -q $url -O - | grep '<title>' | sed 's/<title>\[\(.*\)\] \(.*\) - Java Bug System<\/title>/\1 : \2/' | html_dequote | html_quote`
        fi
        if [[ -z $msg ]]; then
            msg="${id}"
        fi

But such an implementation can certainly be left for later.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git-webrev: create links for bug ids in commit messages

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate d5b6d4ca8fe3fe52185b521865f5a36a8afea013.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 17, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Feb 17, 2020

Just wanted to note that webrev.ksh actually does attempt to fetch the issue title from JBS:

Ah. right, now I remember. We may or may not want to do that, git-webrev is really fast in offline mode 😃

@edvbld
Copy link
Member Author

@edvbld edvbld commented Feb 17, 2020

/integrate

@openjdk openjdk bot closed this Feb 17, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 64bc771: 275: PR bot should allows merge-style PRs with only branch names
  • e4b8ae3: 280: Notifier should support repo/branch prefixes

Your commit was automatically rebased without conflicts.

Pushed as commit d5b6d4c.

@openjdk openjdk bot removed the rfr label Feb 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 17, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: d5b6d4c
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-02-17 16:17:57 +0000
URL: https://git.openjdk.java.net/skara/commit/d5b6d4ca

git-webrev: create links for bug ids in commit messages

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java
! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java
! webrev/src/main/java/org/openjdk/skara/webrev/IndexView.java
! webrev/src/main/java/org/openjdk/skara/webrev/MetadataFormatter.java
! webrev/src/main/java/org/openjdk/skara/webrev/Webrev.java

@mlbridge mlbridge bot mentioned this pull request May 14, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants