Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-pr: recognize more forms on integration comments #448

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 18, 2020

Hi all,

please review this small patch that makes git pr integrate recognize multiple
forms of integration result comments (for example ones with rebase information).

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 18, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git-pr: recognize more forms on integration comments

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 18, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Feb 18, 2020

/integrate

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2020

Webrevs

@openjdk openjdk bot closed this Feb 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2020

@edvbld
Pushed as commit 01d1519.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 01d1519
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-02-18 11:12:41 +0000
URL: https://git.openjdk.java.net/skara/commit/01d1519b

git-pr: recognize more forms on integration comments

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants