Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-pr: rename "update" to "set" #449

Closed
wants to merge 1 commit into from
Closed

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 18, 2020

Hi all,

please review this patch that renames the git pr subcommand update to set.
This is done for a couple of reasons:

  • update can be viewed as appending or enhancing whereas set better reflects
    that we do set some fields (i.e. all existing values for the field has to be
    repeated for appending).
  • update is freed up to be user for future commands
  • set is shorter than update 馃槂

Examples of how the command is intended to be used are git pr set --assignees=rwestberg, git pr set --reviewers=JornVernee and git pr set --no-draft.

Testing:

  • Manual testing of git pr set

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 18, 2020

馃憢 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Sounds good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git-pr: rename "update" to "set"

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 84a1235c47c159f84f0776ff988c84a62e570db4.

鉃★笍 To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 18, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Feb 18, 2020

/integrate

@openjdk openjdk bot closed this Feb 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 84a1235: Add checkout instructions to PR body

Your commit was automatically rebased without conflicts.

Pushed as commit 5c2736f.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 5c2736f
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-02-18 13:15:53 +0000
URL: https://git.openjdk.java.net/skara/commit/5c2736f0

git-pr: rename "update" to "set"

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitPr.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants