Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing newline to PR progress body #453

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 18, 2020

Hi all,

Please review this minor fix that adds a missing newline to the recently updated PR summary body.

Best regards,
Robin

---------### Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/453/head:pull/453
$ git checkout pull/453

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 18, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2020

Webrevs

edvbld
edvbld approved these changes Feb 18, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Add missing newline to PR progress body

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 18, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Feb 18, 2020

/integrate

@openjdk openjdk bot closed this Feb 18, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2020

@rwestberg
Pushed as commit 726cd95.

@openjdk openjdk bot removed the rfr label Feb 18, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 726cd95
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-02-18 15:07:30 +0000
URL: https://git.openjdk.java.net/skara/commit/726cd95c

Add missing newline to PR progress body

Reviewed-by: ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants