Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-pr: set should allow no assignees #462

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 21, 2020

Hi all,

please review this small patch that allows the --assignees option to git pr set to be empty. That is, git pr set --assignees= should make the pull
request have no user assigned to it.

Testing:

  • Manual testing of git pr set --assignees= on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/462/head:pull/462
$ git checkout pull/462

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

mlbridge bot commented Feb 21, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Feb 21, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git-pr: set should allow no assignees

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 21, 2020
@edvbld
Copy link
Member Author

edvbld commented Feb 21, 2020

/integrate

@openjdk openjdk bot closed this Feb 21, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 21, 2020
@openjdk
Copy link

openjdk bot commented Feb 21, 2020

@edvbld
Pushed as commit c309df6.

@openjdk openjdk bot removed the rfr label Feb 21, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: c309df6
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-02-21 10:06:28 +0000
URL: https://git.openjdk.java.net/skara/commit/c309df62

git-pr: set should allow no assignees

Reviewed-by: rwestberg

! args/src/main/java/org/openjdk/skara/args/Argument.java
! args/src/main/java/org/openjdk/skara/args/ArgumentParser.java
! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrSet.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants