Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-pr: set should allow no assignees #462

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -65,7 +65,7 @@ public boolean asBoolean() {
}

public String asString() {
return via(Function.identity());
return value == null ? null : via(Function.identity());
}

public Argument or(int value) {
@@ -161,7 +161,7 @@ public Arguments parse(String[] args) {
if (arg.contains("=")) {
var parts = arg.split("=");
var name = parts[0].substring(2); // remove leading '--'
var value = parts[1];
var value = parts.length == 2 ? parts[1] : null;
var flag = lookupFullname(name);
values.add(new FlagValue(flag, value));
seen.add(flag);
@@ -115,7 +115,9 @@ public static void main(String[] args) throws IOException, InterruptedException
var pr = getPullRequest(uri, repo, host, id);

var assigneesOption = getOption("assignees", "set", arguments);
if (assigneesOption != null) {
if (assigneesOption == null) {
pr.setAssignees(List.of());
} else {
var usernames = Arrays.asList(assigneesOption.split(","));
var assignees = usernames.stream()
.map(u -> host.user(u))