Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-pr: publish later and polish error messages #463

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 21, 2020

Hi all,

please review this patch that ensure that git pr create runs git publish as
late as possible. This is to avoid GitHub showing the "You just pushed a
branch" notification while the user is writing the pull request message in the
editor.

I also polished several of the error messages to provide better info and do
better checks.

Testing:

  • manual testing of git pr create on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/463/head:pull/463
$ git checkout pull/463

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 21, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 21, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 21, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git-pr: publish later and polish error messages

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate c309df62611f36b7d092c45455f14764b5af1cd8.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 21, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Feb 21, 2020

/integrate

@openjdk openjdk bot closed this Feb 21, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 21, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • c309df6: git-pr: set should allow no assignees

Your commit was automatically rebased without conflicts.

Pushed as commit 9a4e98b.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 21, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 9a4e98b
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-02-21 13:02:19 +0000
URL: https://git.openjdk.java.net/skara/commit/9a4e98b5

git-pr: publish later and polish error messages

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrCreate.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants