Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcs: add Hash::zero #469

Closed
wants to merge 1 commit into from
Closed

vcs: add Hash::zero #469

wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 24, 2020

Hi all,

please review this small refactoring that adds the method Hash::zero
representing an empty hash. The zero hash was already used throughout the code
base but in a less clear way.

Testing:

  • make test passes on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/469/head:pull/469
$ git checkout pull/469

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 24, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 24, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 24, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Feb 24, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

vcs: add Hash::zero

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 0e9e8412256251e2c2c182343d21465838f4617f.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 24, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Feb 24, 2020

/integrate

@openjdk openjdk bot closed this Feb 24, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 24, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 0e9e841: Make the rest request error transform optional

Your commit was automatically rebased without conflicts.

Pushed as commit b090b57.

@openjdk openjdk bot removed the rfr label Feb 24, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 24, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: b090b57
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-02-24 14:14:32 +0000
URL: https://git.openjdk.java.net/skara/commit/b090b57c

vcs: add Hash::zero

Reviewed-by: rwestberg

! forge/src/test/java/org/openjdk/skara/forge/CheckBuilderTests.java
! jcheck/src/test/java/org/openjdk/skara/jcheck/BinaryCheckTests.java
! jcheck/src/test/java/org/openjdk/skara/jcheck/ExecutableCheckTests.java
! jcheck/src/test/java/org/openjdk/skara/jcheck/HgTagCommitCheckTests.java
! jcheck/src/test/java/org/openjdk/skara/jcheck/WhitespaceCheckTests.java
! vcs/src/main/java/org/openjdk/skara/vcs/CommitMetadata.java
! vcs/src/main/java/org/openjdk/skara/vcs/Hash.java
! vcs/src/main/java/org/openjdk/skara/vcs/Patch.java
! vcs/src/main/java/org/openjdk/skara/vcs/git/GitCommitMetadata.java
! vcs/src/main/java/org/openjdk/skara/vcs/hg/HgRepository.java
! vcs/src/main/java/org/openjdk/skara/vcs/openjdk/convert/GitToHgConverter.java
! vcs/src/main/java/org/openjdk/skara/vcs/openjdk/convert/HgToGitConverter.java
! vcs/src/test/java/org/openjdk/skara/vcs/RepositoryTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants