Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implementation of addremove #47

wants to merge 1 commit into from


Copy link

@edvbld edvbld commented Aug 16, 2019


this patch fix the implementation of Repository::addremove to use the proper underlying VCS primitives.


  • sh gradlew test passes on Linux x86_64


  • Change must not contain extraneous whitespace
  • Change must be properly reviewed


Copy link

@bridgekeeper bridgekeeper bot commented Aug 16, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

Copy link

@mlbridge mlbridge bot commented Aug 16, 2019


Copy link

@rwestberg rwestberg left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Aug 16, 2019
Copy link

@openjdk openjdk bot commented Aug 16, 2019

@edvbld This change can now be integrated. The commit message will be:

Fix implementation of addremove

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 16, 2019
Copy link
Member Author

@edvbld edvbld commented Aug 16, 2019


Copy link

@openjdk openjdk bot commented Aug 16, 2019

@edvbld Pushed as commit b3d4d7c.

@openjdk openjdk bot closed this Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants