Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-jcheck: add pre-push support #470

Closed
wants to merge 2 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 24, 2020

Hi all,

please review this patch that adds support for the --pre-push and
--setup-pre-push-hook to git-jcheck. Setting up a pre-push hook can
beneficial for OpenJDK projects where contributors push directly (where they
don't use git-pr and pull requests).

Testing:

  • Manual testing on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/470/head:pull/470
$ git checkout pull/470

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 24, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

Copy link
Member

@rwestberg rwestberg left a comment

Looks good, just be consistent with the dash. :)

cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java Outdated Show resolved Hide resolved
@openjdk
Copy link

@openjdk openjdk bot commented Feb 24, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git-jcheck: add pre-push support

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 24, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 24, 2020

Webrevs

Co-Authored-By: Robin Westberg <robin@westberg.se>
@edvbld
Copy link
Member Author

@edvbld edvbld commented Feb 24, 2020

/integrate

@openjdk openjdk bot closed this Feb 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Feb 24, 2020

@edvbld
Pushed as commit bc37f61.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 24, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: bc37f61
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-02-24 15:01:50 +0000
URL: https://git.openjdk.java.net/skara/commit/bc37f619

git-jcheck: add pre-push support

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants