Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper parsing of git diff --raw lines #49

Closed
wants to merge 2 commits into from
Closed

Conversation

@edvbld
Copy link
Member

edvbld commented Aug 16, 2019

Hi,

this patch introduces stricter (and more correct) parsing of the output from git diff --raw. The previous parsing code could not handle spaces in file names.

Testing

  • sh gradlew test

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@openjdk openjdk bot added the rfr label Aug 16, 2019
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 16, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

mlbridge bot commented Aug 16, 2019

Webrevs

Copy link
Member

rwestberg left a comment

Ship it!

@openjdk openjdk bot removed the rfr label Aug 16, 2019
@openjdk
Copy link

openjdk bot commented Aug 16, 2019

@edvbld This change can now be integrated. The commit message will be:

Proper parsing of git diff --raw lines

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Aug 16, 2019
@edvbld
Copy link
Member Author

edvbld commented Aug 16, 2019

Robin only says "Ship it" to be polite, he did tell me to add a test, and so I did! Thanks @rwestberg for enforcing regression tests 👍

@rwestberg
Copy link
Member

rwestberg commented Aug 16, 2019

Even better!

@edvbld
Copy link
Member Author

edvbld commented Aug 16, 2019

/integrate

@openjdk openjdk bot closed this Aug 16, 2019
@openjdk
Copy link

openjdk bot commented Aug 16, 2019

@edvbld Pushed as commit f9979b0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.