Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

295: jcheck should always use configuration from the target branch #491

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Mar 4, 2020

Hi all,

please review this patch that ensures that the bots always use the .jcheck/conf
from the target branch when checking pull requests.

Testing:

  • make test passes on Linux x64
  • Added a few new unit tests

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-295: jcheck should always use configuration from the target branch

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/491/head:pull/491
$ git checkout pull/491

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 4, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 4, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good, we can skip some rebasing done by the bots as well, but that can be fixed later.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

295: jcheck should always use configuration from the target branch

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 4, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Mar 4, 2020

/integrate

@openjdk openjdk bot closed this Mar 4, 2020
@openjdk openjdk bot added the integrated label Mar 4, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2020

@edvbld
Pushed as commit 9fe63b9.

@openjdk openjdk bot removed ready rfr labels Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants