Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quoting to direct comment threading #495

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Mar 4, 2020

Hi all,

Please review this change that checks if a comment contains a quote from a previous post. If it does, that post will be considered the parent when selecting which thread to post in. Also avoid automatic quoting in that case, to let the user select what to quote.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/495/head:pull/495
$ git checkout pull/495

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

mlbridge bot commented Mar 4, 2020

Webrevs

edvbld
edvbld approved these changes Mar 5, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Mar 5, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Use quoting to direct comment threading

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate de5f4b5c8796c419117fb77c12df3809c49a752b.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 5, 2020
@rwestberg
Copy link
Member Author

rwestberg commented Mar 5, 2020

/integrate

@openjdk openjdk bot closed this Mar 5, 2020
@openjdk openjdk bot added the integrated label Mar 5, 2020
@openjdk
Copy link

openjdk bot commented Mar 5, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • de5f4b5: jcheck: make merge committers configurable
  • 0ef146d: jcheck: allow pattern for merge commit messages
  • 07f98f6: jcheck: always reload configuration
  • 9fe63b9: 295: jcheck should always use configuration from the target branch
  • 3cf0696: doc: update README

Your commit was automatically rebased without conflicts.

Pushed as commit eb54331.

@openjdk openjdk bot removed ready rfr labels Mar 5, 2020
@mlbridge
Copy link

mlbridge bot commented Mar 5, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: eb54331
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-03-05 08:19:54 +0000
URL: https://git.openjdk.java.net/skara/commit/eb543319

Use quoting to direct comment threading

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants