Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid an empty line in footers for a comment-only review #499

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Mar 5, 2020

Hi all,

Please review this small change that avoids putting an extra empty line in a bridged review comment, if the review doesn't have a verdict.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/499/head:pull/499
$ git checkout pull/499

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 5, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 5, 2020

Webrevs

edvbld
edvbld approved these changes Mar 5, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 5, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Avoid an empty line in footers for a comment-only review

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate bf4d75aa8c360e9c3f9abc95b9a786b7750b6790.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 5, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Mar 6, 2020

/integrate

@openjdk openjdk bot closed this Mar 6, 2020
@openjdk openjdk bot added integrated and removed ready labels Mar 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 6, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • bf4d75a: Parse older conversations, but only the most recent messages

Your commit was automatically rebased without conflicts.

Pushed as commit 8d9fed4.

@openjdk openjdk bot removed the rfr label Mar 6, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 6, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 8d9fed4
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-03-06 06:54:23 +0000
URL: https://git.openjdk.java.net/skara/commit/8d9fed4c

Avoid an empty line in footers for a comment-only review

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants