Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-webrev: use HEAD when branch has no commits #508

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Mar 11, 2020

Hi all,

please review this small patch that fixes an issue with the default value for
--rev for git-webrev. If the current branch has no commits then
origin..HEAD will be an empty range, so in that case we should just fall back
to HEAD.

Testing:

  • Manual testing of git-webrev on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/508/head:pull/508
$ git checkout pull/508

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 11, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 11, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git-webrev: use HEAD when branch has no commits

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate a2a22376b0106eac1dea23ea73dad57fa3da273d.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 11, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 11, 2020

Webrevs

@edvbld
Copy link
Member Author

@edvbld edvbld commented Mar 11, 2020

/integrate

@openjdk openjdk bot closed this Mar 11, 2020
@openjdk openjdk bot added integrated and removed ready labels Mar 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 11, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • a2a2237: 302: PR body updater should use .jcheck/conf from target branch

Your commit was automatically rebased without conflicts.

Pushed as commit d0eb797.

@openjdk openjdk bot removed the rfr label Mar 11, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 11, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: d0eb797
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-03-11 17:00:12 +0000
URL: https://git.openjdk.java.net/skara/commit/d0eb7970

git-webrev: use HEAD when branch has no commits

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitWebrev.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants