Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

301: Keep track of branch progress per notifier #509

Closed
wants to merge 2 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Mar 13, 2020

Hi all,

Please review this change that makes the repository notifier keep track of the latest reported branch separately for each kind of notifier. This allows other notifications to proceed even if a single notifier fails (such as when the issue tracker is unavailable but email still works).

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewers

  • Erik Helin (ehelin - Reviewer) ⚠️ Review applies to 04abb20

Download

$ git fetch https://git.openjdk.java.net/skara pull/509/head:pull/509
$ git checkout pull/509

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

mlbridge bot commented Mar 13, 2020

Webrevs

@rwestberg rwestberg changed the title Keep track of branch progress per notifier 301: Keep track of branch progress per notifier Mar 13, 2020
edvbld
edvbld approved these changes Mar 13, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, thanks for fixing this Robin!

@openjdk
Copy link

openjdk bot commented Mar 13, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

301: Keep track of branch progress per notifier

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate d0eb79704c7b0516beea0abd3688c01fac5a41af.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 13, 2020
@rwestberg
Copy link
Member Author

rwestberg commented Mar 13, 2020

/integrate

@openjdk openjdk bot closed this Mar 13, 2020
@openjdk openjdk bot added integrated and removed ready labels Mar 13, 2020
@openjdk
Copy link

openjdk bot commented Mar 13, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • d0eb797: git-webrev: use HEAD when branch has no commits
  • a2a2237: 302: PR body updater should use .jcheck/conf from target branch

Your commit was automatically rebased without conflicts.

Pushed as commit 286ccf8.

@openjdk openjdk bot removed the rfr label Mar 13, 2020
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 286ccf8
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-03-13 11:48:12 +0000
URL: https://git.openjdk.java.net/skara/commit/286ccf84

301: Keep track of branch progress per notifier

Reviewed-by: ehelin

! bots/notify/src/main/java/org/openjdk/skara/bots/notify/IssueUpdater.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/JsonUpdater.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryUpdateConsumer.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryWorkItem.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/ResolvedBranch.java
! bots/notify/src/main/java/org/openjdk/skara/bots/notify/UpdateHistory.java
! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdateHistoryTests.java
! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants