Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webrev generation issue when a source hunk is empty #51

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

@rwestberg rwestberg commented Aug 16, 2019

Hi all,

Please review this fix for an index-out-of-bounds when generating a webrev containing an empty source hunk.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@openjdk openjdk bot added the build label Aug 16, 2019
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 16, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Aug 16, 2019
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 16, 2019

Webrevs

@edvbld
edvbld approved these changes Aug 16, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good, reviewed!

@openjdk openjdk bot removed the rfr label Aug 16, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Aug 16, 2019

@rwestberg This change can now be integrated. The commit message will be:

Fix webrev generation issue when a source hunk is empty

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 8f81e32: Cache the value of root() in GitRepository
  • f9979b0: Proper parsing of git diff --raw lines

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Aug 16, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Aug 16, 2019

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 16, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 6f88442.

@openjdk openjdk bot closed this Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants