Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

309: Backport creation fails #511

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Mar 16, 2020

Hi all,

Please review this change that ensures that only known properties are set when creating an issue.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/511/head:pull/511
$ git checkout pull/511

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

mlbridge bot commented Mar 16, 2020

Webrevs

edvbld
edvbld approved these changes Mar 16, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Mar 16, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

309: Backport creation fails

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 16, 2020
@rwestberg
Copy link
Member Author

rwestberg commented Mar 16, 2020

/integrate

@openjdk openjdk bot closed this Mar 16, 2020
@openjdk openjdk bot added integrated and removed ready labels Mar 16, 2020
@openjdk
Copy link

openjdk bot commented Mar 16, 2020

@rwestberg
Pushed as commit 6468f17.

@openjdk openjdk bot removed the rfr label Mar 16, 2020
@mlbridge
Copy link

mlbridge bot commented Mar 16, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 6468f17
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-03-16 14:33:33 +0000
URL: https://git.openjdk.java.net/skara/commit/6468f17b

309: Backport creation fails

Reviewed-by: ehelin

! bots/notify/src/main/java/org/openjdk/skara/bots/notify/RepositoryWorkItem.java
! issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants