Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

310: RFR thread integration messages should check target branch #512

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Mar 16, 2020

Hi all,

Please review this change that ensures that when the notifier sends a threaded integration message, the PR in the RFR thread targets the branch that the notifier is looking at.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-310: RFR thread integration messages should check target branch

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/512/head:pull/512
$ git checkout pull/512

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 16, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 16, 2020

Webrevs

edvbld
edvbld approved these changes Mar 17, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

310: RFR thread integration messages should check target branch

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 6468f17b3dbc025e47dc5234712f74e661a33023.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 17, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Mar 17, 2020

/integrate

@openjdk openjdk bot closed this Mar 17, 2020
@openjdk openjdk bot added integrated and removed ready labels Mar 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 6468f17: 309: Backport creation fails

Your commit was automatically rebased without conflicts.

Pushed as commit 0d08b36.

@openjdk openjdk bot removed the rfr label Mar 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 17, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 0d08b36
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-03-17 08:56:06 +0000
URL: https://git.openjdk.java.net/skara/commit/0d08b363

310: RFR thread integration messages should check target branch

Reviewed-by: ehelin

! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java
! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants