Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

314: Add help command to git-pr #521

Closed
wants to merge 2 commits into from
Closed

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Mar 19, 2020

Hi all,

please review this patch that enhances the default help command for git pr
by quite a bit. git pr will now be default list the usage and flags for all
available sub-commands. A user can now also run git pr help <sub-command>,
e.g. git pr help set:

$ git pr help set
Usage: git pr set [<ID>]
Flags:
  -u, --username NAME   Username on host
  -r, --remote NAME     Name of remote, defaults to 'origin'
      --assignees LIST  Comma separated list of assignees
      --title MESSAGE   The title of the pull request
      --open            Set the pull request's state to open
      --closed          Set the pull request's state to closed
      --body            Set the body of the pull request
      --no-draft        Mark the pull request as not draft
      --verbose         Turn on verbose output
      --debug           Turn on debugging output
      --version         Print the version of this tool

Testing:

  • Manual testing of git pr on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/521/head:pull/521
$ git checkout pull/521

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 19, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 19, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 19, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

314: Add help command to git-pr

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 19f319e785471c980e0199182cb6b1d0558e4f3e.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 19, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Mar 19, 2020

/integrate

@openjdk openjdk bot closed this Mar 19, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 19, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 19f319e: 320: Add "git skara version" command
  • 42caec1: 316: git-webrev does not work without origin remote

Your commit was automatically rebased without conflicts.

Pushed as commit ac71433.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 19, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: ac71433
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-03-19 15:08:06 +0000
URL: https://git.openjdk.java.net/skara/commit/ac71433a

314: Add help command to git-pr

Reviewed-by: rwestberg

! args/src/main/java/org/openjdk/skara/args/ArgumentParser.java
! args/src/main/java/org/openjdk/skara/args/Flag.java
! args/src/main/java/org/openjdk/skara/args/MultiCommandParser.java
! cli/src/main/java/org/openjdk/skara/cli/GitPr.java
! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrApply.java
! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrApprove.java
! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrCheckout.java
! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrClose.java
! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrCreate.java
! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrFetch.java
+ cli/src/main/java/org/openjdk/skara/cli/pr/GitPrHelp.java
! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrInfo.java
! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrIntegrate.java
! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrList.java
! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrSet.java
! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrShow.java
! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrSponsor.java
! cli/src/main/java/org/openjdk/skara/cli/pr/GitPrTest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants