Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

322: Improve error message on non-author /integrate #527

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Mar 23, 2020

Hi all,

Please review this change that gives a more helpful error message if a potential sponsor issues the /integrate command when they probably wanted to do /sponsor.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-322: Improve error message on non-author /integrate

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/527/head:pull/527
$ git checkout pull/527

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 23, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 23, 2020

Webrevs

edvbld
edvbld approved these changes Mar 23, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, great fix!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

322: Improve error message on non-author /integrate

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 2b645bb39d61df4d2b2f276b5330caf19b81b213.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 23, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Mar 23, 2020

/integrate

@openjdk openjdk bot closed this Mar 23, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 1f08f7c: 325: Transient network errors can cause skipped notifications
  • f79bc7a: Ensure pull requests instances are populated with complete json info
  • d1ea8ca: cli: better hg support in git-jcheck
  • b79a80c: jcheck: check for bad whitespace in commit message

Your commit was automatically rebased without conflicts.

Pushed as commit 2b645bb.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 23, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 2b645bb
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-03-23 07:46:18 +0000
URL: https://git.openjdk.java.net/skara/commit/2b645bb3

322: Improve error message on non-author /integrate

Reviewed-by: ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants