Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: better handling of git-jcheck --lax #530

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Mar 23, 2020

Hi all,

please review this PR that handles "lax" for JCheck much better, both when it
comes to CLI reporting and for configuration parsing. Running git jcheck --lax
will now hide a number of issues. The "legacy" JCheck parser now also
understands the comments = lax configuration property.

Testing:

  • make test passes on Linux x64
  • Manual testing of git jcheck --lax

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/530/head:pull/530
$ git checkout pull/530

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 23, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

mlbridge bot commented Mar 23, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good to me!

@openjdk
Copy link

openjdk bot commented Mar 23, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

cli: better handling of git-jcheck --lax

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b2b8de24aa79e5614245fe4ca06177e75cb2f2d5.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 23, 2020
@edvbld
Copy link
Member Author

edvbld commented Mar 23, 2020

/integrate

@openjdk openjdk bot closed this Mar 23, 2020
@openjdk openjdk bot added integrated and removed ready labels Mar 23, 2020
@openjdk
Copy link

openjdk bot commented Mar 23, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • b2b8de2: git-sync: use refspec instead of --prune-tags
  • 2b645bb: 322: Improve error message on non-author /integrate
  • 1f08f7c: 325: Transient network errors can cause skipped notifications

Your commit was automatically rebased without conflicts.

Pushed as commit 4e75eeb.

@openjdk openjdk bot removed the rfr label Mar 23, 2020
@mlbridge
Copy link

mlbridge bot commented Mar 23, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 4e75eeb
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-03-23 08:07:58 +0000
URL: https://git.openjdk.java.net/skara/commit/4e75eeb9

cli: better handling of git-jcheck --lax

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitJCheck.java
! cli/src/main/java/org/openjdk/skara/cli/JCheckCLIVisitor.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesCheck.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesConfiguration.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/JCheckConfiguration.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants