Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jcheck: duplicate-issues should only check id and support "dup" #533

Closed
wants to merge 3 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Mar 23, 2020

Hi all,

please review this patch that makes the "duplicate-issues" check in JCheck
only consider issue ids (e.g. 8123456) when looking for duplicates. I also
added support for the "legacy" .jcheck/conf parser to understands the bugids = dup configuration line.

Testing:

  • Manual testing on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/533/head:pull/533
$ git checkout pull/533

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 23, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Mar 23, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 23, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

jcheck: duplicate-issues should only check id and support "dup"

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 2596472f20df13a21264461fc43f4c1ca6268be8.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 23, 2020
Copy link
Member

@rwestberg rwestberg left a comment

Still looks good!

@edvbld
Copy link
Member Author

@edvbld edvbld commented Mar 23, 2020

/integrate

@openjdk openjdk bot closed this Mar 23, 2020
@openjdk openjdk bot added the integrated label Mar 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 2596472: Reuse HttpClient instances

Your commit was automatically rebased without conflicts.

Pushed as commit 2ccceab.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 23, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 2ccceab
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-03-23 12:49:14 +0000
URL: https://git.openjdk.java.net/skara/commit/2ccceab1

jcheck: duplicate-issues should only check id and support "dup"

Reviewed-by: rwestberg

! jcheck/src/main/java/org/openjdk/skara/jcheck/DuplicateIssuesCheck.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/JCheckConfiguration.java
+ jcheck/src/test/java/org/openjdk/skara/jcheck/DuplicateIssuesCheckTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants