Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hg: add support for skara and focus on webrev, defpath and jcheck #535

Closed
wants to merge 2 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Mar 23, 2020

Hi all,

please review this patch that adds proper support for Mercurial for the
following Skara CLI tools:

  • webrev
  • defpath
  • jcheck
  • skara

Since the above tools except Skara are already backwards compatible with their Mercurial
counterparts in OpenJDK, I only had to do some work on GitSkara.java. Since
the skara tool now is supported a user can now run e.g. hg skara update.

Testing:

  • Manual testing on Linux x64 with hg 4.9.2 and hg 5.3 and Python 2.7.16

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/535/head:pull/535
$ git checkout pull/535

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 23, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 23, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

hg: add support for skara and focus on webrev, defpath and jcheck

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 23, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Mar 23, 2020

/integrate

@openjdk openjdk bot closed this Mar 23, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2020

@edvbld
Pushed as commit 334899a.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 23, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 334899a
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-03-23 14:24:22 +0000
URL: https://git.openjdk.java.net/skara/commit/334899a7

hg: add support for skara and focus on webrev, defpath and jcheck

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitSkara.java
! skara.py
! skara.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants