Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror-bot: support mirroring of selected branches #536

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Mar 24, 2020

Hi all,

please review this patch that enables the mirror bot to mirror only selected
branches (instead of all as is done today). This is useful for projects who
might have a master that is a replica of jdk:master, but don't want tags
(nor potentially other branches) from the
jdk repository.

Testing:

  • make test passes on Linux x64
  • Added a new unit test

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/536/head:pull/536
$ git checkout pull/536

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 24, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 24, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 24, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

mirror-bot: support mirroring of selected branches

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 24, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Mar 24, 2020

Nice. Would it be possible to have an option to also sync reachable tags, using git push --follow-tags in the case where only a single branch is mirrored?

@edvbld
Copy link
Member Author

@edvbld edvbld commented Mar 24, 2020

@kevinrushforth yes, I thought about adding that as the next feature 😃

@edvbld
Copy link
Member Author

@edvbld edvbld commented Mar 24, 2020

/integrate

@openjdk openjdk bot closed this Mar 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 24, 2020

@edvbld
Pushed as commit 1ad79ab.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 24, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 1ad79ab
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-03-24 12:35:34 +0000
URL: https://git.openjdk.java.net/skara/commit/1ad79ab5

mirror-bot: support mirroring of selected branches

Reviewed-by: rwestberg

! bots/mirror/src/main/java/org/openjdk/skara/bots/mirror/MirrorBot.java
! bots/mirror/src/main/java/org/openjdk/skara/bots/mirror/MirrorBotFactory.java
! bots/mirror/src/test/java/org/openjdk/skara/bots/mirror/MirrorBotTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants