Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

321: No RFR mail is sent if a PR is integrated very quickly #538

Closed
wants to merge 2 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Mar 25, 2020

Hi all,

Please review this change that enables sending notification emails for PRs that have been integrated before an RFR mail was created.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-321: No RFR mail is sent if a PR is integrated very quickly

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/538/head:pull/538
$ git checkout pull/538

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 25, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 25, 2020

Webrevs

edvbld
edvbld approved these changes Mar 25, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good! Funny with the "FYI" prefix, I like it 😃

@openjdk
Copy link

@openjdk openjdk bot commented Mar 25, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

321: No RFR mail is sent if a PR is integrated very quickly

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 84586abc126e7fb133d1880455d6968ff579d0e9.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 25, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Mar 25, 2020

/integrate

@openjdk openjdk bot closed this Mar 25, 2020
@openjdk openjdk bot added integrated and removed ready labels Mar 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 25, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • 84586ab: git-pr: use commit message from most recent commit
  • 1ad79ab: mirror-bot: support mirroring of selected branches
  • 0fec136: jcheck: add "problemlists" check
  • 334899a: hg: add support for skara and focus on webrev, defpath and jcheck
  • 2ccceab: jcheck: duplicate-issues should only check id and support "dup"

Your commit was automatically rebased without conflicts.

Pushed as commit 899d3b6.

@openjdk openjdk bot removed the rfr label Mar 25, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 25, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 899d3b6
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-03-25 11:34:32 +0000
URL: https://git.openjdk.java.net/skara/commit/899d3b67

321: No RFR mail is sent if a PR is integrated very quickly

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveItem.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevStorage.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java
! test/src/main/java/org/openjdk/skara/test/TestHost.java
! test/src/main/java/org/openjdk/skara/test/TestHostedRepository.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants