Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitCommitIterator should handle empty commits #54

Closed
wants to merge 1 commit into from

Conversation

@edvbld
Copy link
Member

edvbld commented Aug 16, 2019

HI all,

the GitCommitIterator should be able to handle empty commits. Although empty commits are rare, there are a few in the OpenJDK repositories.

Testing

  • Added two new unit tests
  • sh gradlew test passes on Linux x86_64

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 16, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Aug 16, 2019
@mlbridge
Copy link

mlbridge bot commented Aug 16, 2019

Webrevs

Copy link
Member

rwestberg left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Aug 19, 2019
@openjdk
Copy link

openjdk bot commented Aug 19, 2019

@edvbld This change can now be integrated. The commit message will be:

GitCommitIterator should handle empty commits

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Aug 19, 2019
@edvbld
Copy link
Member Author

edvbld commented Aug 19, 2019

/integrate

@openjdk openjdk bot closed this Aug 19, 2019
@openjdk
Copy link

openjdk bot commented Aug 19, 2019

@edvbld Pushed as commit c19224a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.