Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The merge bot should use hostedrepository with proper credentials #545

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Mar 26, 2020

Hi all,

Please review this small change that ensures that when the merge bot tries to add a label, it uses proper credentials.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/545/head:pull/545
$ git checkout pull/545

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 26, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the bots label Mar 26, 2020
edvbld
edvbld approved these changes Mar 26, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@rwestberg rwestberg changed the title Merge bot should use hostedrepository with proper credentials The merge bot should use hostedrepository with proper credentials Mar 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 26, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

The merge bot should use hostedrepository with proper credentials

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate c4dee6bebc6742ea200c3c3e42060d3b2201faca.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Mar 26, 2020

/integrate

@openjdk openjdk bot closed this Mar 26, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 26, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • c4dee6b: csr-bot: allow other bots to run

Your commit was automatically rebased without conflicts.

Pushed as commit f422eab.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 26, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants