Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge: add HostedRepository.nonTransformedWebUrl #546

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Mar 27, 2020

Hi all,

please review this patch that adds the method HostedRepository.nonTransformedWebUrl. This will be used in a follow-up patch to improve the message from the MergeBot.

Testing:

  • make test passes on Linux x64
  • Added one new unit test

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/546/head:pull/546
$ git checkout pull/546

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 27, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 27, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

forge: add HostedRepository.nonTransformedWebUrl

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 27, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 27, 2020

Webrevs

@edvbld
Copy link
Member Author

@edvbld edvbld commented Mar 27, 2020

/integrate

@openjdk openjdk bot closed this Mar 27, 2020
@openjdk openjdk bot added integrated and removed ready labels Mar 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 27, 2020

@edvbld
Pushed as commit 0bcda97.

@openjdk openjdk bot removed the rfr label Mar 27, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 27, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 0bcda97
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-03-27 14:13:59 +0000
URL: https://git.openjdk.java.net/skara/commit/0bcda973

forge: add HostedRepository.nonTransformedWebUrl

Reviewed-by: rwestberg

! bots/tester/src/test/java/org/openjdk/skara/bots/tester/InMemoryHostedRepository.java
! forge/src/main/java/org/openjdk/skara/forge/HostedRepository.java
! forge/src/main/java/org/openjdk/skara/forge/github/GitHubHost.java
! forge/src/main/java/org/openjdk/skara/forge/github/GitHubRepository.java
! forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabRepository.java
! forge/src/test/java/org/openjdk/skara/forge/github/GitHubHostTests.java
! test/src/main/java/org/openjdk/skara/test/TestHostedRepository.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants