Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

343: Use ssh -G for parsing ssh configuration files #553

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Mar 31, 2020

Hi all,

please review this patch that uses ssh -G instead of relying on my (somewhat
buggy) ssh_config parser. Resolving hosts defined in a ssh_config file is
actually fairly complex and my parser only handled a subset of scenarios. One
drawback is that we now rely on ssh being present on PATH, but that must be
the case if a user has a SSH path for a remote.

Testing:

  • Manual testing using git-webrev with various paths

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-343: Use ssh -G for parsing ssh configuration files

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/553/head:pull/553
$ git checkout pull/553

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 31, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

343: Use `ssh -G` for parsing ssh configuration files

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 31, 2020

Webrevs

@openjdk openjdk bot added the ready label Mar 31, 2020
@pliden
Copy link

@pliden pliden commented Mar 31, 2020

Thanks for fixing! :)

@edvbld
Copy link
Member Author

@edvbld edvbld commented Mar 31, 2020

/integrate

@openjdk openjdk bot closed this Mar 31, 2020
@openjdk openjdk bot added integrated and removed ready labels Mar 31, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2020

@edvbld
Pushed as commit 87965d8.

@openjdk openjdk bot removed the rfr label Mar 31, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 31, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 87965d8
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-03-31 07:48:10 +0000
URL: https://git.openjdk.java.net/skara/commit/87965d81

343: Use `ssh -G` for parsing ssh configuration files

Reviewed-by: rwestberg

! cli/build.gradle
! cli/src/main/java/module-info.java
! cli/src/main/java/org/openjdk/skara/cli/Remote.java
- ssh/build.gradle
- ssh/src/main/java/module-info.java
- ssh/src/main/java/org/openjdk/skara/ssh/SSHConfig.java
- ssh/src/test/java/org/openjdk/ssh/SSHConfigTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants